Fixup #825
Merged
Fixup #825
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet and Facter are confined, work is planned to be able to unpin that. Ship 15 in the meantime.
Incorrectly specified the wrong version (the sha is correct)
mhashizume
approved these changes
Apr 16, 2024
|
@mhashizume sorry i pushed one more commit dealing with solaris/sparc issue in 7.x runtime. can you take a look at that commit too? |
joshcooper
reviewed
Apr 16, 2024
| @@ -1,11 +1,18 @@ | |||
| component "rubygem-semantic_puppet" do |pkg, settings, platform| | |||
| # Projects may define a :rubygem_semantic_puppet_version setting, or we use 1.0.4 by default | |||
| version = settings[:rubygem_semantic_puppet_version] || '1.1.0' | |||
| if platform.is_cross_compiled? && (platform.is_linux? || platform.is_solaris?) | |||
There was a problem hiding this comment.
Suggested change
| if platform.is_cross_compiled? && (platform.is_linux? || platform.is_solaris?) | |
| if platform.is_cross_compiled? && platform.is_solaris? |
… use pl-ruby Copy pattern in ffi component for pinning back to older components on cross compiled platforms that dont use the shipped ruby to build gems.
LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.